Do not remove return type from recursive functions when converting to expression body #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expression body ### What's done: * Changed logic * Added test
… expression body ### What's done: * Changed logic * Added test
… expression body ### What's done: * Changed logic * Added test
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
============================================
- Coverage 84.20% 84.16% -0.05%
Complexity 2352 2352
============================================
Files 101 101
Lines 5977 5986 +9
Branches 1756 1762 +6
============================================
+ Hits 5033 5038 +5
Misses 257 257
- Partials 687 691 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
… expression body ### What's done: * Changed logic * Added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Which rule and warnings did you add?
This pull request closes #903